swarm / rcmgr: synchronize the concurrent outbound dials with limits #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
force-pushed
the
marco/synchronize-limits-with-dials
branch
from
0b7bfc7
to
65a2a55
Compare
MarcoPolo
force-pushed
the
marco/synchronize-limits-with-dials
branch
from
65a2a55
to
92d131b
Compare
|
Oh I see what you meant. This PR didn't build on the quic-v1 branch so there was no point in targeting that branch. I just defaulted to stacking it since it came from that branch, but I should have just based this on master from the start. |
marten-seemann
changed the title
MarcoPolo
force-pushed
the
marco/synchronize-limits-with-dials
branch
from
54432e3
to
aef3657
Compare
|
@marten-seemann and I talked about this and agreed to bump the limit up to 8 for now. This will be handled better when we have smart dialing. |
marten-seemann
approved these changes
Nov 22, 2022
| @@ -492,7 +492,7 @@ var DefaultLimits = ScalingLimitConfig{ | |||
| }, | |||
|
|
|||
| PeerBaseLimit: BaseLimit{ | |||
| ConnsInbound: 4, | |||
| ConnsInbound: 8, | |||
There was a problem hiding this comment.
Can you add a comment explaining why this is 8 for now, and that smart dialing will allow us to reduce this back to 4?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see flakiness in CI because a client will dial with concurrency 8 but the limit on the server is 4 so we get rcmgr failures. We notice this when we have a lot of addrs to dial.
Fixes #1816
Fixes #1765
Fixes #1730
Fixes #1668
(will rebase to master after #1881 is merged)